fix: temporarily removing onboarding wizard for updates #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvineshTripathi
requested review from
mlabouardy,
ShubhamPalriwala,
greghub,
Traxmaxx,
Azanul and
jakepage91
as code owners
|
What is |
|
To create the |
Merged
4 tasks
|
@AvineshTripathi Lets only deactivate the wizard and remove everything other than that. We'll look back again after refactoring. |
AvineshTripathi
force-pushed
the
onboarding-bug
branch
from
da77f68 to
76b31a6
Compare
|
@Azanul this should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarliy sets down the onboaring wizard as the backend support of the feature is still incomplete.
Some changes on the bakend side is done in this PR but since the main functionality will take some time to be figured out it would be better to keep the feature down till then.
Problem: When a cloud in onboarded the only thing the backend does currently is updating the db however scanning the account requires creation of clients and configs which is not possible with the current architecture.